unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: 74860@debbugs.gnu.org
Cc: "Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#74860] [PATCH 00/10] Using the Shepherd's log rotation service
Date: Fri, 13 Dec 2024 23:55:20 +0100	[thread overview]
Message-ID: <cover.1734129908.git.ludo@gnu.org> (raw)

Hello Guix!

Shepherd 1.0 provides a bunch of new features, but now we need to
bring them to Guix System and Guix Home.

This patch series focusing on log rotation: (1) using the Shepherd's
log rotation service, (2) getting rid of Rottlog usage and deprecating
it, and (3) adding log rotation for Home.

Since ‘log-rotation’ only exists in version 1.0 of the Shepherd,
reconfiguring a system that runs an older version of shepherd will
warn that “some services could not be upgraded and reboot may be
needed”.  If the user chooses not to reboot right away, there are
several possibilities:

  • If the mcron service was not unloaded and is still running,
    it will run rottlog as before, that’s fine.

  • If the mcron service was not unloaded, but the user ran
    ‘herd restart mcron’, the new mcron will not have Rottlog
    among its jobs, so log rotation will no longer happen until
    reboot.

  • If the mcron service was unloaded (because nothing else in
    the new system config needed it), then log rotation will no
    longer happen until reboot.

To sum up: worst that can happen is that log rotation stops until
the system is rebooted.  (Of course everything is fine if the
machine already runs Shepherd 1.0.)

That seems acceptable to me, though I guess we can wait for two
weeks before pushing this so more people have upgraded to 1.0.

Thoughts?

Ludo’.

Ludovic Courtès (10):
  gnu: shepherd@1.0: Add dependency on gzip and zstd.
  services: Add ‘log-rotation-service-type’.
  services: log-cleanup: Rewrite as a Shepherd timer.
  services: unattended-upgrade: Rewrite as a Shepherd timer.
  services: Switch from mcron + Rottlog to Shepherd’s log rotation.
  services: rottlog: Deprecate.
  DRAFT news: Add entry for ‘rottlog-service-type’ deprecation.
  home: services: Add log rotation service.
  home: Define ‘%base-home-services’.
  home: Add log rotation to ‘%base-home-services’.

 doc/guix.texi                 | 119 ++++++++++++++++++--
 doc/he-config-bare-bones.scm  |  27 ++---
 etc/news.scm                  |  19 ++++
 gnu/home.scm                  |  11 +-
 gnu/home/services/admin.scm   |  31 ++++++
 gnu/local.mk                  |   1 +
 gnu/packages/admin.scm        |  14 ++-
 gnu/services/admin.scm        | 199 +++++++++++++++++++++++++---------
 gnu/services/audio.scm        |  26 +----
 gnu/services/base.scm         |  10 +-
 gnu/services/cuirass.scm      |  27 +----
 gnu/services/file-sharing.scm |   6 -
 gnu/services/linux.scm        |   8 +-
 gnu/services/networking.scm   |  61 ++---------
 gnu/services/web.scm          |  17 +--
 guix/scripts/home/import.scm  |   8 +-
 tests/home-import.scm         |  40 +++----
 17 files changed, 383 insertions(+), 241 deletions(-)
 create mode 100644 gnu/home/services/admin.scm


base-commit: 0787a180b3ca64d3958438920ca1b58a2a27fba4
-- 
2.46.0





             reply	other threads:[~2024-12-13 22:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-13 22:55 Ludovic Courtès [this message]
2024-12-13 22:58 ` [bug#74860] [PATCH 01/10] gnu: shepherd@1.0: Add dependency on gzip and zstd Ludovic Courtès
2024-12-13 22:58 ` [bug#74860] [PATCH 02/10] services: Add ‘log-rotation-service-type’ Ludovic Courtès
2024-12-13 22:58 ` [bug#74860] [PATCH 03/10] services: log-cleanup: Rewrite as a Shepherd timer Ludovic Courtès
2024-12-13 22:58 ` [bug#74860] [PATCH 04/10] services: unattended-upgrade: " Ludovic Courtès
2024-12-13 22:58 ` [bug#74860] [PATCH 05/10] services: Switch from mcron + Rottlog to Shepherd’s log rotation Ludovic Courtès
2024-12-13 22:58 ` [bug#74860] [PATCH 06/10] services: rottlog: Deprecate Ludovic Courtès
2024-12-13 22:58 ` [bug#74860] [PATCH 07/10] DRAFT news: Add entry for ‘rottlog-service-type’ deprecation Ludovic Courtès
2024-12-14 18:34   ` pelzflorian (Florian Pelz)
2024-12-13 22:58 ` [bug#74860] [PATCH 08/10] home: services: Add log rotation service Ludovic Courtès
2024-12-13 22:58 ` [bug#74860] [PATCH 09/10] home: Define ‘%base-home-services’ Ludovic Courtès
2024-12-13 22:58 ` [bug#74860] [PATCH 10/10] home: Add log rotation to ‘%base-home-services’ Ludovic Courtès
2024-12-13 23:20 ` [bug#74860] [PATCH 00/10] Using the Shepherd's log rotation service Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1734129908.git.ludo@gnu.org \
    --to=ludo@gnu.org \
    --cc=74860@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).