From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: 74394@debbugs.gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: [bug#74394] [PATCH 0/2] Skip slow tests by default and run 'check' in Git pre-push hook.
Date: Sun, 17 Nov 2024 21:03:30 +0900 [thread overview]
Message-ID: <cover.1731844485.git.maxim.cournoyer@gmail.com> (raw)
Hello,
This is a simple change that should ensure test suite breakages are detected
as early as possible and avoid tests breaking changes to be pushed. This is
made possible by skipping a few expensive tests suite, bringing down the total
test time to about 1 minute on a fast machine.
We could call it a "distributed CI" approach ;-).
Note: I initially pursued an Automake or Make-based approach, but it ended up
far from trivial, hitting old issues such as [0] along the way. This solution
simply puts the skip logic in the tests that must be skipped (a one liner).
To run the complete test suite including the slow tests (as is the case prior
this change):
make check WITH_SLOW_TESTS=1
[0] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74387
Maxim Cournoyer (2):
build: Exclude expensive tests in check target by default.
etc: Ensure test suite passes in pre-push git hook.
Makefile.am | 9 ++++++++-
etc/git/pre-push | 1 +
tests/guix-home.sh | 5 +++++
tests/guix-package.sh | 5 +++++
tests/guix-system.sh | 4 ++++
tests/guix-time-machine.sh | 4 +++-
6 files changed, 26 insertions(+), 2 deletions(-)
base-commit: 94133452aa49de672d69950b2e1a99432111074c
--
2.46.0
next reply other threads:[~2024-11-17 12:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-17 12:03 Maxim Cournoyer [this message]
2024-11-17 12:21 ` [bug#74394] [PATCH 1/2] build: Exclude expensive tests in check target by default Maxim Cournoyer
2024-11-17 12:21 ` [bug#74394] [PATCH 2/2] etc: Ensure test suite passes in pre-push git hook Maxim Cournoyer
2024-11-29 10:05 ` [bug#74394] [PATCH 0/2] Skip slow tests by default and run 'check' in Git pre-push hook Ludovic Courtès
2024-12-17 0:28 ` Maxim Cournoyer
2024-12-17 14:51 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1731844485.git.maxim.cournoyer@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=74394@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).