From: Efraim Flashner <efraim@flashner.co.il>
To: Andreas Enge <andreas@enge.fr>
Cc: Julien Lepiller <julien@lepiller.eu>, guix-devel@gnu.org
Subject: Re: Openjdk (was: Merging core-updates?)
Date: Thu, 16 Feb 2023 13:03:35 +0200 [thread overview]
Message-ID: <Y+4NhxsO0tRHdEFE@3900XT> (raw)
In-Reply-To: <Y+0wLKr+7rBroiru@jurong>
[-- Attachment #1: Type: text/plain, Size: 2355 bytes --]
On Wed, Feb 15, 2023 at 08:19:08PM +0100, Andreas Enge wrote:
> Am Wed, Feb 15, 2023 at 07:51:56PM +0100 schrieb Andreas Enge:
> > Actually the patch has already been applied to openjdk13, if I am not
> > mistaken. So I do not understand how the source could be built in master
> > then, while the exact same code (?!) fails on core-updates...
>
> Well, there is a somewhat hidden difference.
> core-updates introduces
> "openjdk-10-hotspot-pointer-comparison.patch"
> "openjdk-10-hotspot-stack-size.patch"
> to openjdk10.
>
> openjdk11 is a package of its own without the patch.
>
> openjdk12 uses the newly defined make-openjdk to start from openjdk11,
> overwriting the source together with openjdk-10-hotspot-stack-size.patch
> in core-updates, and without the patch in master. (And it uses an obscure
> tarball instead of a git checkout - why?)
>
> openjdk13 has the same code in core-updates and master:
> (define-public openjdk13
> (make-openjdk openjdk12 "13.0.13"
> "0pxf4dlig61k0pg7amg4mi919hzam7nzwckry01avgq1wj8ambji"))
> So in core-updates it inherits the patch from openjdk12, in master
> it does not (I think). And then I suppose it passes the patch on to all
> its descendants.
It's definitely possible that the master->core-updates merge messed with
the package definitions and the inheritance and I didn't notice it.
> The following seems to work and create source for openjdk13 and later:
> (define-public openjdk13
> (make-openjdk openjdk12 "13.0.13"
> "0pxf4dlig61k0pg7amg4mi919hzam7nzwckry01avgq1wj8ambji"
> (source (origin
> (inherit (package-source base))
> (patches '())))))
>
> Okay to push if I manage to build current openjdk with it?
Yeah, that's probably fine.
> Is it necessary to keep all these version of openjdk and to bootstrap
> version n with version n-1?
Probably? I assume if you can cut some out that'd be ok. I'm pretty sure
openjdk-11 and openjdk-17 are considered LTS by upstream so it would
make sense to keep those specifically.
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-02-16 11:04 UTC|newest]
Thread overview: 124+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-12 9:05 Merging core-updates? Julien Lepiller
2023-02-12 11:06 ` Andreas Enge
2023-02-12 11:52 ` Julien Lepiller
2023-02-12 11:58 ` Julien Lepiller
2023-02-12 13:05 ` Christopher Baines
2023-02-20 11:10 ` Christopher Baines
2023-02-12 17:08 ` Andreas Enge
2023-02-12 18:29 ` Kaelyn
2023-02-13 20:04 ` Efraim Flashner
2023-02-13 21:36 ` Kaelyn
2023-02-14 14:50 ` Efraim Flashner
2023-02-14 20:29 ` Kaelyn
2023-02-15 0:07 ` Kaelyn
2023-02-12 18:40 ` Janneke Nieuwenhuizen
2023-02-13 11:34 ` Janneke Nieuwenhuizen
2023-02-13 13:57 ` Andreas Enge
2023-02-15 8:39 ` Janneke Nieuwenhuizen
2023-02-16 14:19 ` Andreas Enge
2023-02-16 15:03 ` bug#49985: " Janneke Nieuwenhuizen
2023-02-16 15:24 ` Andreas Enge
2023-02-16 15:33 ` Julien Lepiller
2023-02-12 14:49 ` Josselin Poiret
2023-02-13 3:05 ` John Kehayias
2023-02-12 12:02 ` Leo Famulari
2023-02-21 23:01 ` Ludovic Courtès
2023-02-12 13:28 ` Christopher Baines
2023-03-05 19:52 ` Christopher Baines
2023-03-05 22:18 ` Merging core-updates? OFF TOPIC PRAISE Joshua Branson
2023-02-12 15:51 ` Merging core-updates? Efraim Flashner
2023-02-13 16:40 ` Katherine Cox-Buday
2023-02-13 17:11 ` John Kehayias
2023-02-13 20:22 ` Andreas Enge
2023-02-13 20:38 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-02-13 9:43 ` zimoun
2023-02-13 10:56 ` Architecture support [was: Re: Merging core-updates?] Efraim Flashner
2023-02-13 12:59 ` Architecture support Andreas Enge
2023-02-14 16:30 ` Architecture support [was: Re: Merging core-updates?] Andreas Enge
2023-02-14 16:40 ` Julien Lepiller
2023-02-15 9:45 ` Architecture support Andreas Enge
2023-02-17 16:49 ` Architecture support [was: Re: Merging core-updates?] Christopher Baines
2023-02-19 22:50 ` Architecture support Andreas Enge
2023-02-20 9:23 ` Christopher Baines
2023-02-14 20:10 ` Architecture support [was: Re: Merging core-updates?] Efraim Flashner
2023-02-15 9:35 ` Andreas Enge
2023-02-13 20:35 ` Merging core-updates? Andreas Enge
2023-02-13 21:31 ` Efraim Flashner
2023-02-14 18:27 ` Andreas Enge
2023-02-15 18:51 ` Andreas Enge
2023-02-15 19:19 ` Openjdk (was: Merging core-updates?) Andreas Enge
2023-02-16 11:03 ` Efraim Flashner [this message]
2023-02-16 11:38 ` Julien Lepiller
2023-02-18 11:28 ` Andreas Enge
2023-02-17 10:36 ` Andreas Enge
2023-02-17 14:49 ` Andreas Enge
2023-02-17 16:28 ` Andreas Enge
2023-02-17 17:27 ` Kaelyn
2023-02-18 10:55 ` Andreas Enge
2023-02-16 11:41 ` Merging core-updates? Maxime Devos
2023-02-16 16:03 ` Andreas Enge
2023-02-18 11:03 ` Ocaml (was: Merging core-updates?) Andreas Enge
2023-02-18 11:38 ` Andreas Enge
2023-02-19 9:15 ` Julien Lepiller
2023-02-20 10:35 ` Simon Tournier
2023-02-20 11:16 ` Julien Lepiller
2023-02-20 11:55 ` Ocaml Andreas Enge
2023-02-19 11:02 ` Python (was: Merging core-updates?) Andreas Enge
2023-02-19 11:15 ` Andreas Enge
2023-02-19 11:19 ` Andreas Enge
2023-02-19 15:10 ` Attila Lendvai
2023-02-21 16:24 ` Python Andreas Enge
2023-02-19 11:30 ` Python (was: Merging core-updates?) Andreas Enge
2023-02-19 20:31 ` Python Andreas Enge
2023-02-21 16:41 ` Python Andreas Enge
2023-02-22 14:23 ` Python Andreas Enge
2023-02-23 15:16 ` Python Andreas Enge
2023-02-24 16:47 ` Python Andreas Enge
2023-02-24 16:51 ` Python Andreas Enge
2023-02-24 18:08 ` Python Lars-Dominik Braun
2023-02-25 15:15 ` Python Andreas Enge
2023-02-25 15:45 ` Python Lars-Dominik Braun
2023-02-25 16:39 ` Python Andreas Enge
2023-02-25 16:56 ` Python Lars-Dominik Braun
2023-02-25 18:00 ` Python Andreas Enge
2023-02-25 18:06 ` Python Andreas Enge
2023-02-25 18:15 ` Python Andreas Enge
2023-02-25 18:33 ` Python Andreas Enge
2023-02-27 19:14 ` Python Lars-Dominik Braun
2023-02-28 15:05 ` Python Andreas Enge
2023-02-25 18:29 ` Python Andreas Enge
2023-03-11 11:20 ` Python Andreas Enge
2023-03-11 11:44 ` Python Andreas Enge
2023-03-15 13:49 ` Python Andreas Enge
2023-03-18 8:59 ` Python Lars-Dominik Braun
2023-03-18 9:15 ` Python Andreas Enge
2023-03-18 10:02 ` Python Lars-Dominik Braun
2023-03-18 10:13 ` Python Andreas Enge
2023-03-18 9:43 ` Python Lars-Dominik Braun
2023-03-18 19:37 ` Python Andreas Enge
2023-03-21 18:56 ` Python Lars-Dominik Braun
2023-03-30 9:57 ` Python Lars-Dominik Braun
2023-03-30 10:10 ` Python Andreas Enge
2023-04-03 17:29 ` PyQt in core-updates Andreas Enge
2023-04-04 7:55 ` Lars-Dominik Braun
2023-04-17 8:32 ` Andreas Enge
2023-03-30 11:05 ` Python Lars-Dominik Braun
2023-03-31 8:52 ` Python Andreas Enge
2023-02-27 18:55 ` Python Efraim Flashner
2023-02-27 19:12 ` Python Lars-Dominik Braun
2023-02-21 16:50 ` Python (was: Merging core-updates?) Andreas Enge
2023-02-19 11:47 ` Lars-Dominik Braun
2023-02-19 11:57 ` Andreas Enge
2023-02-19 15:50 ` Lars-Dominik Braun
2023-02-19 20:27 ` Python Andreas Enge
2023-02-25 17:44 ` Python Andreas Enge
2023-02-19 21:35 ` Python (was: Merging core-updates?) Andreas Enge
2023-02-19 22:08 ` Andreas Enge
2023-02-19 22:59 ` Kaelyn
2023-02-21 16:18 ` Andreas Enge
2023-02-19 19:55 ` Andreas Enge
2023-02-19 11:48 ` Andreas Enge
2023-02-19 22:24 ` Andreas Enge
2023-02-21 16:58 ` Andreas Enge
2023-02-22 9:40 ` Icecat (was: Python) Andreas Enge
2023-02-16 20:11 ` Merging core-updates? Josselin Poiret
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+4NhxsO0tRHdEFE@3900XT \
--to=efraim@flashner.co.il \
--cc=andreas@enge.fr \
--cc=guix-devel@gnu.org \
--cc=julien@lepiller.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).