From: zimoun <zimon.toutoune@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Guix Devel <guix-devel@gnu.org>
Subject: Re: branch master updated (0aa0e1f -> 9b7f9e6)
Date: Mon, 24 Feb 2020 17:36:15 +0100 [thread overview]
Message-ID: <CAJ3okZ1Rns2ZmbqY3xXr8QAn6bMeCcQA-qBnDz7ohCNMbGyNhQ@mail.gmail.com> (raw)
In-Reply-To: <87blpom285.fsf@gnu.org>
Hi Ludo,
On Mon, 24 Feb 2020 at 16:33, Ludovic Courtès <ludo@gnu.org> wrote:
> guix-commits@gnu.org skribis:
>
> > new d7545a6 ui: Only display link in capable terminals.
> > new 672d3d4 ui: Don't disable colors when INSIDE_EMACS is set.
>
> Forgive me if I missed the discussion, but I thought we had reached
> rough consensus in favor of the status quo. What happened?
I do not know if we had reached a consensus. :-)
Here [1] is explained the 2 issues. One issue comes from *eshell* and
should be solved upstream, as explained here [2] and has been already
explained by Ricardo there [3]. Upstream bug report is opened, AFAICT,
and merged soon [4].
The other issue is "that the OSC is not always supported and some
terminal emulators are not doing the correct thing. For example EShell
or (incorrectly build) Mate of Trisquel. Therefore, instead of
displaying this special character, just print the full path of the
generation file and the commit url." [5]. And this is not related to
Emacs and/or INSIDE_EMACS but related to the support of the OSC by the
terminal emulator. And the highlighting is another topic.
Well, from my understanding, the question was about the name of this
variable "INSIDE_EMACS" to replace the OSC by the full path and
how/where to document it, see Pierre's message [6] but then Ricardo
answered [7]: "we should not document it in Guix, nor should we rename
it to GUIX_INSIDE_EMACS".
Maybe the misunderstanding comes from there.
[1] https://lists.gnu.org/archive/html/guix-devel/2020-02/msg00188.html
[2] https://lists.gnu.org/archive/html/guix-devel/2020-02/msg00199.html
[3] https://lists.gnu.org/archive/html/guix-devel/2020-02/msg00040.html
[4] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=39596
[5] https://lists.gnu.org/archive/html/guix-devel/2020-02/msg00164.html
[6] https://lists.gnu.org/archive/html/guix-devel/2020-02/msg00029.html
[7] https://lists.gnu.org/archive/html/guix-devel/2020-02/msg00031.html
Cheers,
simon
next prev parent reply other threads:[~2020-02-24 16:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200224101817.20439.52918@vcs0.savannah.gnu.org>
2020-02-24 15:31 ` branch master updated (0aa0e1f -> 9b7f9e6) Ludovic Courtès
2020-02-24 15:40 ` Pierre Neidhardt
2020-02-24 16:36 ` zimoun [this message]
2020-02-24 20:34 ` Ludovic Courtès
2020-02-24 21:22 ` Pierre Neidhardt
2020-02-24 23:00 ` zimoun
2020-02-24 23:45 ` Jelle Licht
[not found] ` <20200224101818.9A1FC206ED@vcs0.savannah.gnu.org>
2020-02-24 15:35 ` 01/03: ui: Only display link in capable terminals Ludovic Courtès
2020-02-24 16:15 ` Pierre Neidhardt
2020-02-24 20:38 ` Ludovic Courtès
2020-02-24 21:23 ` Pierre Neidhardt
2020-02-27 23:16 ` Ludovic Courtès
2020-02-28 7:10 ` Pierre Neidhardt
2020-02-28 14:29 ` zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ3okZ1Rns2ZmbqY3xXr8QAn6bMeCcQA-qBnDz7ohCNMbGyNhQ@mail.gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).