From: zimoun <zimon.toutoune@gmail.com>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: Guix Devel <guix-devel@gnu.org>
Subject: Re: Guix search, colors and INSIDE_EMACS
Date: Tue, 4 Feb 2020 17:40:54 +0100 [thread overview]
Message-ID: <CAJ3okZ1LerS0R5M1-kOUYZNFFnKqiPh0aa=xNpuR-e73dW2L_A@mail.gmail.com> (raw)
In-Reply-To: <87tv46qqlf.fsf@elephly.net>
[-- Attachment #1: Type: text/plain, Size: 748 bytes --]
Hi Ricardo,
On Tue, 4 Feb 2020 at 17:12, Ricardo Wurmus <rekado@elephly.net> wrote:
> > - Rename it to GUIX_INSIDE_EMACS?
> > - Document the existence of INSIDE_EMACS.
>
> The variable is set by Emacs. As an Emacs feature we should not
> document it in Guix, nor should we rename it to GUIX_INSIDE_EMACS.
This is mitigated by foreign distro using bad packaged terminal, see e.g. [1].
[1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38940
And a couple of days, I was annoyed by this so I patched, see attached.
Note that 'guix system describe' has also the "issue" and do not use
the same function to display, I guess.
Otherwise, the OSC issue should be fixed by Emacs 27, I guess.
So the rename is probably not useful.
Cheers,
simon
[-- Attachment #2: fix-describe.patch --]
[-- Type: text/x-patch, Size: 2542 bytes --]
diff --git a/guix/scripts/pull.scm b/guix/scripts/pull.scm
index cb1be989e1..408db70555 100644
--- a/guix/scripts/pull.scm
+++ b/guix/scripts/pull.scm
@@ -210,9 +210,11 @@ Download and deploy the latest version of Guix.\n"))
(define* (channel-commit-hyperlink channel
#:optional
- (commit (channel-commit channel)))
+ (commit (channel-commit channel))
+ (transformer hyperlink))
"Return a hyperlink for COMMIT in CHANNEL, using COMMIT as the hyperlink's
-text. The hyperlink links to a web view of COMMIT, when available."
+text. The hyperlink links to a web view of COMMIT, when available.
+TRANSFORMER allows to control how the uri and text are."
(let* ((url (channel-url channel))
(uri (string->uri url))
(host (and uri (uri-host uri))))
@@ -221,7 +223,7 @@ text. The hyperlink links to a web view of COMMIT, when available."
(#f
commit)
((_ template)
- (hyperlink (template url commit) commit)))
+ (transformer (template url commit) commit)))
commit)))
(define* (display-profile-news profile #:key concise?
@@ -583,7 +585,11 @@ way and displaying details about the channel's source code."
(format #t (G_ " commit: ~a~%")
(if (supports-hyperlinks?)
(channel-commit-hyperlink channel commit)
- commit))))
+ commit))
+ (when (not (supports-hyperlinks?))
+ (format #t (G_ " URL: ~a~%")
+ (channel-commit-hyperlink channel commit
+ (lambda (url msg) url))))))
(_ #f)))
;; Show most recently installed packages last.
diff --git a/guix/ui.scm b/guix/ui.scm
index 4857a88827..ee56c23362 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -1625,7 +1625,7 @@ DURATION-RELATION with the current time."
(let* ((file (generation-file-name profile number))
(link (if (supports-hyperlinks?)
(cut file-hyperlink file <>)
- identity))
+ (cut format #f (G_ "~a~%file: ~a") <> file)))
(header (format #f (link (highlight (G_ "Generation ~a\t~a")))
number
(date->string
next prev parent reply other threads:[~2020-02-04 16:41 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 15:23 Guix search, colors and INSIDE_EMACS Pierre Neidhardt
2020-02-04 16:12 ` Ricardo Wurmus
2020-02-04 16:37 ` Pierre Neidhardt
2020-02-04 16:51 ` zimoun
2020-02-04 19:16 ` Ricardo Wurmus
2020-02-04 19:18 ` Ricardo Wurmus
2020-02-06 9:51 ` Pierre Neidhardt
2020-02-13 9:30 ` zimoun
2020-02-13 13:41 ` Alex Griffin
2020-02-13 14:22 ` zimoun
2020-02-14 7:17 ` Pierre Neidhardt
2020-02-14 7:21 ` Pierre Neidhardt
2020-02-17 7:51 ` Pierre Neidhardt
2020-02-17 7:54 ` zimoun
2020-02-17 13:42 ` Pierre Neidhardt
2020-02-17 18:33 ` zimoun
2020-02-24 10:19 ` Pierre Neidhardt
2020-02-24 16:22 ` Ludovic Courtès
2020-02-24 16:44 ` Pierre Neidhardt
2020-02-24 17:11 ` zimoun
2020-02-24 20:54 ` Ludovic Courtès
2020-02-24 21:32 ` Pierre Neidhardt
2020-02-24 16:53 ` zimoun
2020-02-05 15:13 ` Ludovic Courtès
2020-02-06 9:56 ` Pierre Neidhardt
2020-02-07 21:33 ` Ludovic Courtès
2020-02-08 16:34 ` Pierre Neidhardt
2020-02-04 16:40 ` zimoun [this message]
2020-02-10 19:36 ` Pierre Neidhardt
2020-02-10 23:24 ` zimoun
2020-02-11 6:22 ` Pierre Neidhardt
2020-02-11 14:11 ` Ludovic Courtès
2020-02-11 14:19 ` Pierre Neidhardt
2020-02-11 15:14 ` zimoun
2020-02-11 16:37 ` Jack Hill
2020-02-11 18:09 ` zimoun
2020-02-11 19:04 ` Jack Hill
2020-02-12 13:39 ` Pierre Neidhardt
2020-02-12 16:30 ` zimoun
2020-02-13 9:35 ` zimoun
2020-02-24 16:18 ` Ludovic Courtès
2020-02-24 16:45 ` Pierre Neidhardt
2020-02-24 16:59 ` zimoun
2020-02-24 16:50 ` zimoun
2020-02-11 15:11 ` zimoun
2020-02-11 15:06 ` zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ3okZ1LerS0R5M1-kOUYZNFFnKqiPh0aa=xNpuR-e73dW2L_A@mail.gmail.com' \
--to=zimon.toutoune@gmail.com \
--cc=guix-devel@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).