From: zimoun <zimon.toutoune@gmail.com>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 43946-done@debbugs.gnu.org
Subject: [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section.
Date: Sat, 24 Oct 2020 11:17:03 +0200 [thread overview]
Message-ID: <CAJ3okZ0ANAfyWVbgUEe1Ryv35C9OA7CS-4bx_ey5YTmisi_tPQ@mail.gmail.com> (raw)
In-Reply-To: <87d0189ev4.fsf@gmail.com>
Dear,
Thank you for the review.
On Sat, 24 Oct 2020 at 11:01, Oleg Pykhalov <go.wigust@gmail.com> wrote:
> zimoun <zimon.toutoune@gmail.com> writes:
>
> > * doc/contributing.texi (Submitting Patches): Add item about 'git-format-patch
> > --base'.
> > ---
> > doc/contributing.texi | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/doc/contributing.texi b/doc/contributing.texi
> > index af3601442e..5ea3cb1899 100644
> > --- a/doc/contributing.texi
> > +++ b/doc/contributing.texi
> > @@ -932,6 +932,12 @@ Before submitting a patch that adds or modifies a package definition,
> > please run through this check list:
> >
> > @enumerate
> > +@cindex @code{git format-patch}
> > +@cindex @code{git-format-patch}
> > +@item
> > +We recommend to use the command @code{git format-patch --base} to
> > +include the commit where your patch applies.
>
> “git format-patch” already mentioned in the documentation in the first
> paragraph https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html
The point of the patch is:
- the addition of the cindex
- the addition of the option --base
and AFAITC it is not already in the manual. If it is the wrong place,
please let me know where it could be better.
All the best,
simon
next prev parent reply other threads:[~2020-10-24 9:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 8:20 [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section zimoun
2020-10-24 9:01 ` bug#43946: " Oleg Pykhalov
2020-10-24 9:17 ` zimoun [this message]
2021-01-15 13:30 ` [bug#43946] " Ludovic Courtès
2021-01-15 14:00 ` zimoun
2021-03-26 5:40 ` zimoun
2021-09-21 9:53 ` zimoun
2021-09-22 13:02 ` bug#43946: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ3okZ0ANAfyWVbgUEe1Ryv35C9OA7CS-4bx_ey5YTmisi_tPQ@mail.gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=43946-done@debbugs.gnu.org \
--cc=go.wigust@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).