From: Philip Kaludercic <philipk@posteo.net>
To: Daniel Mendler <mail@daniel-mendler.de>
Cc: 74556@debbugs.gnu.org
Subject: bug#74556: 30.0.92; Package upgrade can fail and results in deleted package
Date: Thu, 28 Nov 2024 11:11:33 +0000 [thread overview]
Message-ID: <87zflj62ai.fsf@posteo.net> (raw)
In-Reply-To: <87plmgq55e.fsf@daniel-mendler.de> (Daniel Mendler's message of "Wed, 27 Nov 2024 12:37:17 +0100")
[-- Attachment #1: Type: text/plain, Size: 920 bytes --]
Daniel Mendler <mail@daniel-mendler.de> writes:
> Package upgrade can fail when the package metadata is out of sync. The
> upgrade process first deletes the package, tries to download the new
> version. If the download fails for some reason (metadata out of sync or
> the file not available), the upgrade aborts but the earlier package
> deletion is not rolled back as one would expect for an upgrade
> transaction. Ideally the download would be performed first such that the
> upgrade process wouldn't lead to a missing package.
>
> I just executed M-x package-upgrade-all. The following messages appeared
> in the log:
>
> Package ‘<package>-<old-version>’ deleted.
> Contacting host: elpa.gnu.org:443
> package--with-response-buffer-1:
> https://elpa.gnu.org/devel/<pkgname>-<new-version>.tar: No Data
I cannot test this out right now, but it seems that the fix should be
straight-forward
[-- Attachment #2: Type: text/plain, Size: 1182 bytes --]
diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 438af781393..46b2d7580c1 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -2268,12 +2268,16 @@ package-upgrade
;; `pkg-desc' will be nil when the package is an "active built-in".
(if (and pkg-desc (package-vc-p pkg-desc))
(package-vc-upgrade pkg-desc)
- (when pkg-desc
- (package-delete pkg-desc 'force 'dont-unselect))
(package-install package
;; An active built-in has never been "selected"
;; before. Mark it as installed explicitly.
- (and pkg-desc 'dont-select)))))
+ (and pkg-desc 'dont-select))
+ ;; We delete the old package via the descriptor after installing
+ ;; the new package to avoid losing the package if there issues
+ ;; during installation (Bug#74556).
+ (cl-assert (package-desc-dir pkg-desc))
+ (when pkg-desc
+ (package-delete pkg-desc 'force 'dont-unselect)))))
(defun package--upgradeable-packages (&optional include-builtins)
;; Initialize the package system to get the list of package
[-- Attachment #3: Type: text/plain, Size: 234 bytes --]
It might make sense to try and "deactivate" a package before installing
the new package. Looking into some second-try fallback for
package-install to refresh the package index if a package was not found
would also be a good idea ^^
next prev parent reply other threads:[~2024-11-28 11:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 11:37 bug#74556: 30.0.92; Package upgrade can fail and results in deleted package Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-28 11:11 ` Philip Kaludercic [this message]
2024-11-28 11:34 ` Philip Kaludercic
2024-12-07 12:29 ` Eli Zaretskii
2024-12-07 20:48 ` Philip Kaludercic
2024-12-10 15:05 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-10 20:12 ` Philip Kaludercic
2024-12-10 20:24 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-10 20:31 ` Philip Kaludercic
2024-12-11 3:30 ` Eli Zaretskii
2024-12-11 3:34 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zflj62ai.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=74556@debbugs.gnu.org \
--cc=mail@daniel-mendler.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).