unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed

From: Christopher Baines <mail@cbaines.net>
To: guix-devel@gnu.org
Subject: Thoughts on committers pushing simple changes from other committers?
Date: Tue, 21 Feb 2023 12:54:32 +0000	[thread overview]
Message-ID: <87y1ordv5p.fsf@cbaines.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 812 bytes --]

Hey!

So probably in part due to the recent changes to the commit policy [1] I
think there are more "simple" changes being sent to guix-patches by
committers, which I think is good, but that's got me thinking about the
process for these changes.

1: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=9aa2b7419854306b7ae78d4c4f7684316b834b1d

Generally, I don't push changes for other committers, but I wonder if
that would be helpful now.

Take #61416 [2] as an example, I replied saying the change looked good
to me, but maybe it would be easier if I'd just pushed it along with the
changes I was pushing for non-committers?

2: https://issues.guix.gnu.org/61416

Obviously I think this wouldn't apply to all changes, just the simpler
ones (for some vauge definition of simpler).

Thoughts?

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

next             reply	other threads:[~2023-02-21 13:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21 12:54 Christopher Baines [this message]
2023-02-21 14:57 ` Thoughts on committers pushing simple changes from other committers? Andreas Enge
2023-02-21 18:00   ` Leo Famulari
2023-02-22  9:35     ` Andreas Enge
2023-02-21 17:58 ` Leo Famulari
2023-02-21 18:52 ` Vagrant Cascadian
2023-02-21 21:20   ` Simon Tournier
2023-02-25 18:06     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1ordv5p.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).