From: Philip Kaludercic <philipk@posteo.net>
To: Daniel Mendler <mail@daniel-mendler.de>
Cc: 74556@debbugs.gnu.org
Subject: bug#74556: 30.0.92; Package upgrade can fail and results in deleted package
Date: Thu, 28 Nov 2024 11:34:51 +0000 [thread overview]
Message-ID: <87v7w7617o.fsf@posteo.net> (raw)
In-Reply-To: <87zflj62ai.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 28 Nov 2024 11:11:33 +0000")
[-- Attachment #1: Type: text/plain, Size: 316 bytes --]
Philip Kaludercic <philipk@posteo.net> writes:
[...]
> It might make sense to try and "deactivate" a package before installing
> the new package. Looking into some second-try fallback for
> package-install to refresh the package index if a package was not found
> would also be a good idea ^^
This might do it?
[-- Attachment #2: Type: text/plain, Size: 1299 bytes --]
diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 438af781393..3800d8fa56d 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -2095,7 +2095,7 @@ package-archive-base
"Return the package described by DESC."
(cdr (assoc (package-desc-archive desc) package-archives)))
-(defun package-install-from-archive (pkg-desc)
+(defun package-install-from-archive-1 (pkg-desc)
"Download and install a package defined by PKG-DESC."
;; This won't happen, unless the archive is doing something wrong.
(when (eq (package-desc-kind pkg-desc) 'dir)
@@ -2141,6 +2141,15 @@ package-install-from-archive
package-alist))))
(setf (package-desc-signed (car pkg-descs)) t))))))))))
+(defun package-install-from-archive (pkg-desc)
+ "Download and install PKG-DESC, refreshing the archive if necessary."
+ (condition-case msg
+ (package-install-from-archive-1 pkg-desc)
+ (error
+ (when (string-match-p "\\`Error retrieving: " (cadr msg))
+ (package-refresh-contents)
+ (package-install-from-archive-1 pkg-desc)))))
+
;;;###autoload
(defun package-installed-p (package &optional min-version)
"Return non-nil if PACKAGE, of MIN-VERSION or newer, is installed.
next prev parent reply other threads:[~2024-11-28 11:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 11:37 bug#74556: 30.0.92; Package upgrade can fail and results in deleted package Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-28 11:11 ` Philip Kaludercic
2024-11-28 11:34 ` Philip Kaludercic [this message]
2024-12-07 12:29 ` Eli Zaretskii
2024-12-07 20:48 ` Philip Kaludercic
2024-12-10 15:05 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-10 20:12 ` Philip Kaludercic
2024-12-10 20:24 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-10 20:31 ` Philip Kaludercic
2024-12-11 3:30 ` Eli Zaretskii
2024-12-11 3:34 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v7w7617o.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=74556@debbugs.gnu.org \
--cc=mail@daniel-mendler.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).