From: "Ludovic Courtès" <ludo@gnu.org>
To: Brice Waegeneire <brice@waegenei.re>
Cc: 49610@debbugs.gnu.org
Subject: [bug#49610] [PATCH 0/2] Add channels field to guix-configuration
Date: Wed, 21 Jul 2021 23:53:36 +0200 [thread overview]
Message-ID: <87sg07e3kv.fsf_-_@gnu.org> (raw)
In-Reply-To: <20210717210424.1921-2-brice@waegenei.re> (Brice Waegeneire's message of "Sat, 17 Jul 2021 23:04:24 +0200")
Brice Waegeneire <brice@waegenei.re> skribis:
> * doc/guix.texi (Channels): Specify that '/etc/guix/channels.scm'
> contains channels configuration.
> (Base Services): Document 'guix-configuration-channels' field.
> * gnu/services/base.scm (setup-channels): New procedure.
> (guix-configuration): Add channels field.
> (guix-activation): Use 'setup-channels' procedure.
[...]
> +@item @code{channels} (default: @code{'()})
> +List of system channels to use, it populates
> +@file{/etc/guix/channels.scm}.
What about:
List of channels to be used by @command{guix pull}, by default.
Channels listed here are written to @file{/etc/guix/channels.scm}.
?
> +;; FIXME Does this gexp should be build before boot, such as
> +;; substitute-key-authorization does?
There’s a grammatical issue :-), but also I’m not sure: what are you
worried about?
> +(define (setup-channels channels)
> + "Return a gexp with code to setup CHANNELS, a list of channels"
Missing period. For the name, how about ‘install-channels-file’
instead?
> + (channels guix-configuration-channels ;list of channels
> + (default '()))
I wonder if it should default to ‘%default-channels’, for consistency
and least-surprise. In practice, it means we’d always end up creating
/etc/guix/channels.scm, but that’s probably OK. (The downside is if we,
Guix devs, choose to change ‘%default-channels’ at some point: users
would be stuck with the value that got written to /etc. That’s a very
hypothetical situation though.)
WDYT?
> + #$(if (not (null? channels))
> + (setup-channels channels)
> #~#f))))
In that case, we could remove the (null? channels) special case.
Thanks,
Ludo’.
next prev parent reply other threads:[~2021-07-21 21:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-17 20:58 [bug#49610] [PATCH 0/2] Add channels field to guix-configuration Brice Waegeneire
2021-07-17 21:04 ` [bug#49610] [PATCH 1/2] services: guix: Use "match-record" in activation Brice Waegeneire
2021-07-21 21:47 ` [bug#49610] [PATCH 0/2] Add channels field to guix-configuration Ludovic Courtès
2021-08-04 4:42 ` Brice Waegeneire
2021-07-17 21:04 ` [bug#49610] [PATCH 2/2] services: guix: Add channels field Brice Waegeneire
2021-07-21 21:53 ` Ludovic Courtès [this message]
2021-09-01 21:16 ` [bug#49610] [PATCH 0/2] Add channels field to guix-configuration Ludovic Courtès
2021-12-21 21:00 ` [bug#49610] [PATCH v2] sevices: guix: Add channels field Brice Waegeneire
2022-01-03 11:32 ` Ludovic Courtès
2023-05-25 20:12 ` [bug#49610] [PATCH v3] services: " Antero Mejr via Guix-patches via
2023-05-26 10:40 ` Simon Tournier
2023-05-26 16:29 ` Antero Mejr via Guix-patches via
2023-05-26 16:26 ` [bug#49610] [PATCH v4 1/2] " Antero Mejr via Guix-patches via
2023-05-26 16:26 ` [bug#49610] [PATCH v4 2/2] doc: guix.texi: Clarify wording in Channels section Antero Mejr via Guix-patches via
2024-03-22 10:45 ` Ludovic Courtès
2024-03-22 10:44 ` [bug#49610] [PATCH v4 1/2] services: guix: Add channels field Ludovic Courtès
2024-03-24 10:24 ` [bug#49610] [PATCH 0/2] Add channels field to guix-configuration Franz Geffke
2024-04-04 8:03 ` Simon Tournier
2024-04-09 8:44 ` Franz Geffke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg07e3kv.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=49610@debbugs.gnu.org \
--cc=brice@waegenei.re \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).