From: Marius Bakke <mbakke@fastmail.com>
To: Ben Woodcroft <b.woodcroft@uq.edu.au>, Leo Famulari <leo@famulari.name>
Cc: guix-devel <guix-devel@gnu.org>, Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH] gnu: Add dlib.
Date: Wed, 17 Aug 2016 15:48:24 +0100 [thread overview]
Message-ID: <87h9ajzc1z.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <d29f34fd-d2b6-26a3-3c3a-1ac35ef59e56@uq.edu.au>
[-- Attachment #1: Type: text/plain, Size: 2050 bytes --]
Ben Woodcroft <b.woodcroft@uq.edu.au> writes:
> On 17/08/16 09:45, Leo Famulari wrote:
>> On Wed, Aug 17, 2016 at 09:31:11AM +1000, Ben Woodcroft wrote:
>>>
>>> On 17/08/16 06:47, Leo Famulari wrote:
>>>> On Tue, Aug 16, 2016 at 11:45:16AM +0100, Marius Bakke wrote:
>>>>> I initially made this package on a foreign distro without "lapack" in
>>>>> inputs and have verified that dropping LAPACK makes the tests pass.
>>>>>
>>>>> I also found some other optional dependencies after digging around the
>>>>> source, as well as a recommendation to disable/enable asserts:
>>>>>
>>>>> http://dlib.net/dlib/config.h.html
>>>>>
>>>>> Ben, Leo: Can you try the following patch and see if that works for you?
>>>> Yes, this patch builds for me.
>>> Me too, although it appeared non-deterministic. I'm afraid I haven't time to
>>> see if this patch is suitable to push just now. Leo?
>> How did it appear non-deterministic to you?
> Just based on guix build --check:
>
> guix build: error: build failed: derivation
> `/gnu/store/sxybcxw64q1ajzq6dysal75ffgq6238i-dlib-19.1.drv' may not be
> deterministic: output
> `/gnu/store/il57dcii4pzii11zlixjjxxxw699bg5x-dlib-19.1' differs
>
> I'm actually not sure, why does it say "may not be deterministic"? If it
> builds twice and the second version is different, doesn't that mean it
> is definitely not deterministic by counter-example, unless there has
> been some leakage into the build container?
>
> I also tried building it with #parallel-build? #f and #parallel-tests?
> #f. It worked in the first round but failed the second.
>
> Note also that the 'disable-asserts' phase should end with '#t'.
I've attached a patch with a #t in the disable-asserts phase, and also
deleting the 6MB static library.
Since `guix build --rounds=2` passes, is there any reason to delay this
patch? I've built this on GuixSD and a foreign distro and naively
verified that they are the same (the .so and all headers have the same
checksum; some of the recorded cmake input paths are different though).
Thanks,
Marius
[-- Attachment #2: 0001-gnu-Add-dlib.patch --]
[-- Type: text/x-patch, Size: 4627 bytes --]
From 77f74972d095aeb08367e00c9d683137bd7a35f3 Mon Sep 17 00:00:00 2001
From: Marius Bakke <mbakke@fastmail.com>
Date: Sat, 13 Aug 2016 11:26:10 +0100
Subject: [PATCH] gnu: Add dlib.
* gnu/packages/machine-learning.scm (dlib): New variable.
---
gnu/packages/machine-learning.scm | 67 ++++++++++++++++++++++++++++++++++++++-
1 file changed, 66 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm
index f96672c..4332045 100644
--- a/gnu/packages/machine-learning.scm
+++ b/gnu/packages/machine-learning.scm
@@ -1,6 +1,7 @@
;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2015, 2016 Ricardo Wurmus <rekado@elephly.net>
;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
+;;; Copyright © 2016 Marius Bakke <mbakke@fastmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -27,18 +28,21 @@
#:use-module (guix build-system gnu)
#:use-module (guix build-system r)
#:use-module (gnu packages)
+ #:use-module (gnu packages algebra)
#:use-module (gnu packages autotools)
#:use-module (gnu packages boost)
#:use-module (gnu packages compression)
#:use-module (gnu packages dejagnu)
#:use-module (gnu packages gcc)
+ #:use-module (gnu packages image)
#:use-module (gnu packages maths)
#:use-module (gnu packages perl)
#:use-module (gnu packages pkg-config)
#:use-module (gnu packages python)
#:use-module (gnu packages statistics)
#:use-module (gnu packages swig)
- #:use-module (gnu packages xml))
+ #:use-module (gnu packages xml)
+ #:use-module (gnu packages xorg))
(define-public libsvm
(package
@@ -467,3 +471,64 @@ geometric models.")
"This package provides functions for feed-forward neural networks with a
single hidden layer, and for multinomial log-linear models.")
(license (list license:gpl2+ license:gpl3+))))
+
+(define-public dlib
+ (package
+ (name "dlib")
+ (version "19.1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append
+ "http://dlib.net/files/dlib-" version ".tar.bz2"))
+ (sha256
+ (base32
+ "0p2pvcdalc6jhb6r99ybvjd9x74sclr0ngswdg9j2xl5pj7knbr4"))
+ (modules '((guix build utils)))
+ (snippet
+ '(begin
+ ;; Delete ~13MB of bundled dependencies.
+ (delete-file-recursively "dlib/external")
+ (delete-file-recursively "docs/dlib/external")))))
+ (build-system cmake-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'disable-asserts
+ (lambda _
+ ;; config.h recommends explicitly enabling or disabling asserts
+ ;; when building as a shared library. By default neither is set.
+ (substitute* "dlib/config.h"
+ (("^//#define DLIB_DISABLE_ASSERTS") "#define DLIB_DISABLE_ASSERTS"))
+ #t))
+ (replace 'check
+ (lambda _
+ ;; No test target, so we build and run the unit tests here.
+ (let ((test-dir (string-append "../dlib-" ,version "/dlib/test/build")))
+ (mkdir-p test-dir)
+ (with-directory-excursion test-dir
+ (and (zero? (system* "cmake" ".."))
+ (zero? (system* "cmake" "--build" "." "--config" "Release"))
+ (zero? (system* "./dtest" "--runall")))))))
+ (add-after 'install 'delete-static-library
+ (lambda* (#:key outputs #:allow-other-keys)
+ (delete-file (string-append (assoc-ref outputs "out") "/lib/libdlib.a")))))))
+ (native-inputs
+ `(("pkg-config" ,pkg-config)))
+ (inputs
+ `(("fftw" ,fftw)
+ ("giflib" ,giflib)
+ ;("lapack" ,lapack) XXX lapack here causes test failures in some setups.
+ ("libjpeg" ,libjpeg)
+ ("libpng" ,libpng)
+ ("libx11" ,libx11)
+ ("openblas" ,openblas)
+ ("zlib" ,zlib)))
+ (synopsis
+ "Toolkit for making machine learning and data analysis applications in C++")
+ (description
+ "Dlib is a modern C++ toolkit containing machine learning algorithms and
+tools. It is used in both industry and academia in a wide range of domains
+including robotics, embedded devices, mobile phones, and large high performance
+computing environments.")
+ (home-page "http://dlib.net")
+ (license license:boost1.0)))
--
2.9.2
next prev parent reply other threads:[~2016-08-17 14:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-13 17:15 [PATCH] gnu: Add dlib Marius Bakke
2016-08-14 17:25 ` Leo Famulari
2016-08-14 19:52 ` Marius Bakke
2016-08-15 7:43 ` Alex Kost
2016-08-15 11:51 ` Marius Bakke
2016-08-15 20:15 ` Leo Famulari
2016-08-15 20:29 ` Marius Bakke
2016-08-15 22:28 ` Leo Famulari
2016-08-16 0:15 ` Ben Woodcroft
2016-08-16 10:45 ` Marius Bakke
2016-08-16 20:47 ` Leo Famulari
2016-08-16 23:31 ` Ben Woodcroft
2016-08-16 23:45 ` Leo Famulari
2016-08-17 3:24 ` Ben Woodcroft
2016-08-17 5:01 ` Ben Woodcroft
2016-08-17 14:48 ` Marius Bakke [this message]
2016-08-18 20:23 ` Leo Famulari
2016-08-19 10:52 ` Marius Bakke
2016-08-21 20:17 ` Leo Famulari
2016-08-22 2:30 ` Ben Woodcroft
2016-08-22 12:01 ` Marius Bakke
2016-08-23 18:33 ` Marius Bakke
2016-08-24 10:26 ` Marius Bakke
2016-08-24 17:26 ` Leo Famulari
2016-08-24 19:08 ` Marius Bakke
2016-08-24 22:51 ` Ben Woodcroft
2016-08-30 14:43 ` Marius Bakke
2016-08-31 19:09 ` Leo Famulari
2016-09-09 12:15 ` Marius Bakke
2016-09-10 12:32 ` Marius Bakke
2016-09-10 18:16 ` Leo Famulari
2016-09-13 5:14 ` Leo Famulari
2016-09-13 5:14 ` Leo Famulari
2016-08-18 20:18 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9ajzc1z.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me \
--to=mbakke@fastmail.com \
--cc=alezost@gmail.com \
--cc=b.woodcroft@uq.edu.au \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).