From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 61853@debbugs.gnu.org
Subject: bug#61853: ‘guix pack’ shell tests fail
Date: Fri, 03 Mar 2023 22:22:10 -0500 [thread overview]
Message-ID: <87bkl942vx.fsf@gmail.com> (raw)
In-Reply-To: <87cz5qyv10.fsf@gnu.org> ("Ludovic Courtès"'s message of "Fri, 03 Mar 2023 11:43:55 +0100")
Hi,
Ludovic Courtès <ludo@gnu.org> writes:
> Hi Maxim,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>> Ludovic Courtès <ludo@gnu.org> writes:
>
> [...]
>
>>> That’s an acceptable change IMO, introduced in
>>> 68380db4c40a2ee1156349a87254fd7b1f1a52d5. However, the tests were
>>> evidently not run after that change, which is problematic.
>>
>> Interesting. I had done all my testing using tests/pack.scm (and the
>> new tests/rpm.scm), and overlooked tests/pack.sh.
>
> …
>
>>> Anyway, fixed in 92a0e60a963a54230e400c5c2ae585205489bf35. Both tests
>>> now pass for me.
>>
>> Thanks (again)!
>
> To be clear, it’s time-consuming and stressful. That’s not sane and I’d
> rather not work that way.
Again, thanks for fixing up after me, but you didn't need to put
yourself under such pressure. As the author of the problematic change,
the responsibility of fixing it was on me; I understand this well.
>>> One issue with 68380db4c40a2ee1156349a87254fd7b1f1a52d5, though, is that
>>> it introduces a copy of the profile being built to the store
>>> (“profile-directory”). This was purposefully avoided before because
>>> it’s very I/O-intensive, space-consuming, and puts more pressure on the
>>> store. It’s a pattern we avoided for system images too, having noticed
>>> its cost (commit 7f75a7ec08975eb6d6e01db61bd6b91f447f655e for instance.)
>>>
>>> We may need to come back to a single derivation well or creating packs
>>> for big profiles will be too costly.
>>
>> I agree it's expensive; we're trading IO for storage though, so the case
>> of generating the same pack in multiple format, it could be beneficial
>> by only computing the union directory once. The real motivation was
>> avoiding code duplication though; perhaps this could be accomplished by
>> moving the common logic to (guix build pack-utils)?
>
> Yes, that’s a good idea. There’s already (guix build pack) and I guess
> we could move roughly the contents of ‘self-contained-tarball/builder’
> and ‘populate-profile-root’ there.
>
> How does that sound?
Sounds good. See an implementation in #61949, to which you should be
CC'd already (per 'etc/teams.scm cc-members HEAD^ HEAD').
--
Thanks,
Maxim
prev parent reply other threads:[~2023-03-04 3:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 21:46 bug#61853: ‘guix pack’ shell tests fail Ludovic Courtès
2023-02-27 23:07 ` Ludovic Courtès
2023-02-28 2:15 ` Maxim Cournoyer
2023-03-03 10:43 ` Ludovic Courtès
2023-03-04 3:22 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkl942vx.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=61853@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).