From: Alex Kost <alezost@gmail.com>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add dlib.
Date: Mon, 15 Aug 2016 10:43:44 +0300 [thread overview]
Message-ID: <87a8gexyrz.fsf@gmail.com> (raw)
In-Reply-To: <87twengmbh.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> (Marius Bakke's message of "Sun, 14 Aug 2016 20:52:34 +0100")
Marius Bakke (2016-08-14 22:52 +0300) wrote:
Hello and welcome!
> From 5e30eff1cf24b236a78cc5abed870992e84f443f Mon Sep 17 00:00:00 2001
> From: Marius Bakke <mbakke@fastmail.com>
> Date: Sat, 13 Aug 2016 11:26:10 +0100
> Subject: [PATCH] gnu: Add dlib.
[...]
> +(define-public dlib
> + (package
> + (name "dlib")
> + (version "19.1")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "http://dlib.net/files/dlib-" version ".tar.bz2"))
> + (sha256
> + (base32
> + "0p2pvcdalc6jhb6r99ybvjd9x74sclr0ngswdg9j2xl5pj7knbr4"))
> + (modules '((guix build utils)))
> + (snippet
> + '(begin
> + ;; Delete ~13MB of bundled dependencies.
> + (delete-file-recursively "dlib/external")
> + (delete-file-recursively "docs/dlib/external")))))
> + (build-system cmake-build-system)
> + (arguments
> + `(#:phases
> + (let ((test-dir (string-append "../dlib-" ,version "/dlib/test/build")))
I think it's better to move this 'let' inside the phase: ...
> + (modify-phases %standard-phases
> + (replace 'check
> + ;; No test target, so we build and run the unit tests here.
> + (lambda _
... here.
> + (mkdir-p test-dir)
> + (with-directory-excursion test-dir
> + (zero? (system* "cmake" ".."))
> + (zero? (system* "cmake" "--build" "." "--config" "Release"))
> + (zero? (system* "./dtest" "--runall")))))))))
There is no point in the first 2 'zero?' calls as their returning
values will be lost, rather:
(and (zero? (system* "cmake" ".."))
(zero? (system* "cmake" "--build" "." "--config" "Release"))
(zero? (system* "./dtest" "--runall")))
> + (native-inputs
> + `(("pkg-config" ,pkg-config)))
> + (inputs
> + `(("lapack" ,lapack)
> + ("libjpeg" ,libjpeg)
> + ("libpng" ,libpng)
> + ("libx11" ,libx11)
> + ("openblas" ,openblas)
> + ("zlib" ,zlib)))
> + (synopsis "Toolkit for making machine learning and data analysis applications in C++")
> + (description
> + "Dlib is a modern C++ toolkit containing machine learning algorithms and tools. It
> +is used in both industry and academia in a wide range of domains including robotics,
> +embedded devices, mobile phones, and large high performance computing environments.")
As for me, the above lines (in synopsis and description) are too long, I
would stay inside 72-78 columns.
> + (home-page "http://dlib.net")
> + (license license:boost1.0)))
Otherwise, the patch looks good to me, so if Leo or other people don't
have comments, I think it can be committed.
--
Alex
next prev parent reply other threads:[~2016-08-15 7:43 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-13 17:15 [PATCH] gnu: Add dlib Marius Bakke
2016-08-14 17:25 ` Leo Famulari
2016-08-14 19:52 ` Marius Bakke
2016-08-15 7:43 ` Alex Kost [this message]
2016-08-15 11:51 ` Marius Bakke
2016-08-15 20:15 ` Leo Famulari
2016-08-15 20:29 ` Marius Bakke
2016-08-15 22:28 ` Leo Famulari
2016-08-16 0:15 ` Ben Woodcroft
2016-08-16 10:45 ` Marius Bakke
2016-08-16 20:47 ` Leo Famulari
2016-08-16 23:31 ` Ben Woodcroft
2016-08-16 23:45 ` Leo Famulari
2016-08-17 3:24 ` Ben Woodcroft
2016-08-17 5:01 ` Ben Woodcroft
2016-08-17 14:48 ` Marius Bakke
2016-08-18 20:23 ` Leo Famulari
2016-08-19 10:52 ` Marius Bakke
2016-08-21 20:17 ` Leo Famulari
2016-08-22 2:30 ` Ben Woodcroft
2016-08-22 12:01 ` Marius Bakke
2016-08-23 18:33 ` Marius Bakke
2016-08-24 10:26 ` Marius Bakke
2016-08-24 17:26 ` Leo Famulari
2016-08-24 19:08 ` Marius Bakke
2016-08-24 22:51 ` Ben Woodcroft
2016-08-30 14:43 ` Marius Bakke
2016-08-31 19:09 ` Leo Famulari
2016-09-09 12:15 ` Marius Bakke
2016-09-10 12:32 ` Marius Bakke
2016-09-10 18:16 ` Leo Famulari
2016-09-13 5:14 ` Leo Famulari
2016-09-13 5:14 ` Leo Famulari
2016-08-18 20:18 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8gexyrz.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).