unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludovic.courtes@inria.fr>
Cc: Mathieu Othacehe <othacehe@gnu.org>,
	Matthieu Haefele <matthieu.haefele@cnrs.fr>,
	58149@debbugs.gnu.org, zimoun <zimon.toutoune@gmail.com>
Subject: bug#58149: Letting clients warn about old daemons
Date: Mon, 03 Oct 2022 11:12:25 -0400	[thread overview]
Message-ID: <87a66dj606.fsf@gmail.com> (raw)
In-Reply-To: <87sfk51dmv.fsf_-_@inria.fr> ("Ludovic Courtès"'s message of "Mon, 03 Oct 2022 11:04:56 +0200")

Hi,

Ludovic Courtès <ludovic.courtes@inria.fr> writes:

> Hi,
>
> (Cc: Mathieu O. + Maxim.)
>
> Matthieu Haefele <matthieu.haefele@cnrs.fr> skribis:
>
>> I worked intensively with guix this summer, I did not get any
>> deprecation warnings, I am quite sure. And I still do not get any. So
>> might be a good idea to check the deprecation machinery.
>>
>> (base) mhaefele@mdlspc113:~ $ guix shell python-numpy python coreutils
>> (base) mhaefele@mdlspc113:~ $ echo $GUIX_ENVIRONMENT
>> /gnu/store/cy8y10jfnbq5y2r16i13q04h1lii428a-profile
>
> Indeed.  I’ve just realized that commit
> f9c62b23cc88541756656b3ec602ce987828d906, which added that deprecation
> warning, will actually only fire with daemons dating back from before
> 2018 (the date at which ‘PROTOCOL_VERSION’ was last updated in
> ‘worker-protocol.hh’).  Going back to this issue at hand, it won’t
> report a daemon that lacks lzip support.

The commit to the daemon that bumped that protocol is dated Oct 15 2018:
--8<---------------cut here---------------start------------->8---
commit 6ef61cc4c30e94acbd7437f19c893f63a7112267
Author: Ludovic Courtès <ludo@gnu.org>
Date:   Mon Oct 15 22:40:35 2018 +0200

    daemon: Support multiplexed build output.
    
    [...]
    (%protocol-version): Bump to #x163.
    * tests/store.scm ("multiplexed-build-output"): New test.
--8<---------------cut here---------------end--------------->8---

Which would have gotten distributed in a pullable 'guix' with:

--8<---------------cut here---------------start------------->8---
commit 532f92c8f39ef8fa9441bf0840ae642016fac7a5
Author: Ludovic Courtès <ludo@gnu.org>
Date:   Mon Oct 15 23:54:20 2018 +0200

    gnu: guix: Update to f9a8fce.
    
    * gnu/packages/package-management.scm (guix): Update to f9a8fce.
--8<---------------cut here---------------end--------------->8---

That indeed doesn't correspond to the time when lzip was introduced.

> Mathieu, Maxim: I think we need a finer-grain mechanism here, or maybe a
> new builtin that would let a client ask the daemon for supported
> features.

That'd be nice indeed.

Thanks,

-- 
Maxim




  reply	other threads:[~2022-10-03 15:13 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-28 15:47 bug#58149: guix pull error Matthieu Haefele
2022-09-28 22:06 ` zimoun
2022-09-29 13:37   ` Ludovic Courtès
2022-09-29 15:04     ` Matthieu Haefele
2022-09-29 15:15       ` Ludovic Courtès
2022-09-29 15:35         ` Matthieu Haefele
2022-09-29 17:55           ` Maxime Devos
2022-09-30  6:09             ` Matthieu Haefele
2022-09-30  7:59           ` Ludovic Courtès
2022-09-30  9:42             ` Matthieu Haefele
2022-10-03  9:04               ` bug#58149: Letting clients warn about old daemons Ludovic Courtès
2022-10-03 15:12                 ` Maxim Cournoyer [this message]
2022-10-03  9:17               ` bug#58149: guix pull error Ludovic Courtès
2022-10-03  9:33                 ` Matthieu Haefele
2022-10-03 14:03                   ` Ludovic Courtès
2022-10-03 14:49                     ` Matthieu Haefele
2022-10-04 10:11                       ` Ludovic Courtès
2022-10-04 13:01                         ` Matthieu Haefele
2022-10-05  9:34                           ` Ludovic Courtès
2022-10-05 10:47                             ` Matthieu Haefele
2022-10-05 10:52                               ` Matthieu Haefele
2022-10-05 15:02                               ` zimoun
2022-10-05 15:08                                 ` Matthieu Haefele
2022-10-06  8:47                               ` Ludovic Courtès
2022-10-06 10:10                                 ` Matthieu Haefele
2022-10-06 10:30                                   ` zimoun
2022-10-06 12:14                                     ` Matthieu Haefele
2022-10-06 13:56                                       ` zimoun
2022-10-06 15:15                                         ` Matthieu Haefele
2022-10-06 15:38                                           ` zimoun
2022-10-06 16:00                                         ` Maxime Devos
2022-10-06 16:01                                     ` Ludovic Courtès
2022-10-06 10:57                                   ` Maxime Devos
2022-10-06 12:08                                     ` Matthieu Haefele
2022-10-06 15:56                                       ` Maxime Devos
2022-10-06 15:58                                   ` Ludovic Courtès
2022-10-05 14:36                             ` Matthieu Haefele
2022-10-07  2:40                         ` bokr
2022-10-14 12:19                           ` zimoun
2022-10-03 20:47 ` bug#58149: Unable to pull when using a pre-lzip version of guix-daemon Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a66dj606.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=58149@debbugs.gnu.org \
    --cc=ludovic.courtes@inria.fr \
    --cc=matthieu.haefele@cnrs.fr \
    --cc=othacehe@gnu.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).