From: ludo@gnu.org (Ludovic Courtès)
To: Christopher Allan Webber <cwebber@dustycloud.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: guile: Add guile-irregex.
Date: Fri, 06 Nov 2015 16:15:18 +0100 [thread overview]
Message-ID: <874mgzjh15.fsf@gnu.org> (raw)
In-Reply-To: <87egg3dy0f.fsf@dustycloud.org> (Christopher Allan Webber's message of "Fri, 06 Nov 2015 08:03:57 -0600")
Christopher Allan Webber <cwebber@dustycloud.org> skribis:
> On a side note, it would really be nice to have a
> r6rs-build-system... starting to result in a lot of similar spaghetti in
> a few of these packages.
Is there really a standard R6 way of doing things?
I agree some factorization would be welcome anyhow!
> From 38edbac8ab42e1518424fd2da4d53ece2c96094c Mon Sep 17 00:00:00 2001
> From: Christopher Allan Webber <cwebber@dustycloud.org>
> Date: Thu, 5 Nov 2015 12:20:03 -0600
> Subject: [PATCH] gnu: guile: Add guile-irregex.
>
> * gnu/packages/guile.scm (guile-irregex): New variable.
[...]
> + `(#:modules ((guix build utils)
> + (ice-9 match)
> + ,@%gnu-build-system-modules)
I think (guix build gnu-build-system) is enough on the 3rd line.
> + (synopsis "S-expression based regular expressions, packaged for Guile")
I’d remove “, packaged for Guile”.
Otherwise LGTM, thank you!
Ludo’.
next prev parent reply other threads:[~2015-11-06 15:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 14:03 [PATCH] gnu: guile: Add guile-irregex Christopher Allan Webber
2015-11-06 15:15 ` Ludovic Courtès [this message]
2015-11-06 16:58 ` Christopher Allan Webber
2015-11-07 18:59 ` Efraim Flashner
2015-11-09 15:34 ` Christopher Allan Webber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mgzjh15.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=cwebber@dustycloud.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).